fix: fail over mail server addresses - #319
Open
YunQue0912 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #318.
Mail server hostnames can resolve to several valid addresses, but MailFlow previously pinned every connection to the first one. An unreachable first address therefore blocked IMAP and SMTP even when another validated address was healthy. SMTP's default connection timeout could also outlive the frontend proxy timeout.
Changes
CONNfailures, before authentication or envelope/data commands, so failover cannot duplicate delivered messages.Testing
npm run lintnode --check src/index.js710passed across35files0vulnerabilitiesnpm run lintnpm run build1401passed across48suitesaudit-level=high: passed (two existing moderate React Router advisories have no available fix)git diff --checkContributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).