feat: add Samsung TV Tizen ID support - #33
Conversation
Recreate the implementation and test from mParticle#31 with LF line endings and an unreleased changelog entry. Co-authored-by: Ignacio Linari <ignacio.linari@rokt.com>
PR SummaryLow Risk Overview Adds Reviewed by Cursor Bugbot for commit 34632c1. Bugbot is set up for automated code reviews on this repo. Configure here. |
jamesnrokt
left a comment
There was a problem hiding this comment.
Approved but noting when I was verifying the format I couldn't see the platform type showing on docs, do we need a followup PR there?
Thanks James! The current JSON reference already includes samsung_tv and tizen_advertising_id. The older /developers/server/ link appears broken and is being redirected. |
Java server integrations can now represent Samsung TV devices and include their Tizen Advertising ID in
device_info. Adds the Samsung TV platform option, thetizen_advertising_idproperty, and coverage for its accessors and JSON round trip.Recreates #31 with a signed commit and LF line endings so the functional changes are easy to review. Credits Ignacio Linari as co-author and adds an unreleased changelog entry.
Validation: SDK assembly and all six local-only tests passed on JDK 17. A separate request-construction check confirmed that the real Retrofit serializer includes the Tizen Advertising ID. Maven Central returned HTTP 429, so local validation used a temporary Google Maven Central mirror configuration; repository build settings are unchanged. The existing
uploadCustomEventTest, which sends requests to the production S2S endpoint, was excluded. No live ingestion or release was performed.