Skip to content

feat: add Samsung TV Tizen ID support - #33

Merged
jamesnrokt merged 1 commit into
mParticle:mainfrom
bhanwadiyaaditya:feat/identity-2222-samsung-tv-tizen-id-signed
Sep 3, 2026
Merged

feat: add Samsung TV Tizen ID support#33
jamesnrokt merged 1 commit into
mParticle:mainfrom
bhanwadiyaaditya:feat/identity-2222-samsung-tv-tizen-id-signed

Conversation

@bhanwadiyaaditya

Copy link
Copy Markdown
Contributor

Java server integrations can now represent Samsung TV devices and include their Tizen Advertising ID in device_info. Adds the Samsung TV platform option, the tizen_advertising_id property, and coverage for its accessors and JSON round trip.

Recreates #31 with a signed commit and LF line endings so the functional changes are easy to review. Credits Ignacio Linari as co-author and adds an unreleased changelog entry.

Validation: SDK assembly and all six local-only tests passed on JDK 17. A separate request-construction check confirmed that the real Retrofit serializer includes the Tizen Advertising ID. Maven Central returned HTTP 429, so local validation used a temporary Google Maven Central mirror configuration; repository build settings are unchanged. The existing uploadCustomEventTest, which sends requests to the production S2S endpoint, was excluded. No live ingestion or release was performed.

Recreate the implementation and test from mParticle#31 with LF line endings and an unreleased changelog entry.

Co-authored-by: Ignacio Linari <ignacio.linari@rokt.com>
@cursor

cursor Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Additive model and enum fields with tests; no changes to auth, networking, or existing platform behavior.

Overview
Extends DeviceInformation so server-side event payloads can identify Samsung TV clients and carry a Tizen advertising identifier in device_info.

Adds SAMSUNG_TV (samsung_tv) to PlatformEnum, plus a tizen_advertising_id field with fluent setter, getters/setters, and updates to equals, hashCode, and toString. A unit test checks enum resolution, accessors, and Gson JSON round-trip. CHANGELOG.md documents the addition under [Unreleased].

Reviewed by Cursor Bugbot for commit 34632c1. Bugbot is set up for automated code reviews on this repo. Configure here.

@jamesnrokt jamesnrokt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but noting when I was verifying the format I couldn't see the platform type showing on docs, do we need a followup PR there?

@bhanwadiyaaditya

bhanwadiyaaditya commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Approved but noting when I was verifying the format I couldn't see the platform type showing on docs, do we need a followup PR there?

Thanks James! The current JSON reference already includes samsung_tv and tizen_advertising_id. The older /developers/server/ link appears broken and is being redirected.

@jamesnrokt
jamesnrokt merged commit d8fda88 into mParticle:main Sep 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants