Skip to content

docs: board comments drawer and the review rule selector - #987

Merged
m4ttheweric merged 3 commits into
mainfrom
docs-threads-reply-rule-selector
Nov 4, 2026
Merged

m4ttheweric merged 3 commits into
mainfrom
docs-threads-reply-rule-selector

Conversation

@m4ttheweric

@m4ttheweric m4ttheweric commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Fills two docs gaps from v2.28.0: replying from the board's comments drawer, and the review rule selector (#948, #951, #957), which had no page.

What changed

Board (website/docs/apps/board.mdx)

  • Adds a Comments and threads section: the thread count, the drawer, reply, send & resolve, resolve rules
  • Adds a "Read and answer review comments" line to What you do in it

Skills (website/docs/skills/rule-selector.mdx)

  • New page: where the selector runs, binding it, the fill's shapes, the verdict set, how fails become findings, review.ruleSelector
  • Links it from the Skills index

Verification

Every claim was checked against CommentsDrawer.tsx, the rule-selector contract block and the design spec. check_docs 0 errors on all three pages, docs:check and docs:build clean, and both pages were viewed in Fast Browser in light and dark.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Documented how to open a board row’s comments drawer, review and reply to comments, and resolve threads. Clarified which review threads and merge request comments appear, which feedback is excluded, and how comment counts and indicators are shown.
    • Explained that local-board replies and resolutions are written sequentially, with errors reported per thread.
    • Added a link to the Review rule selector guide, covering stage bindings, configuration, selection formats, verdicts, validation, and failure handling. Noted that selectors are disabled by default.

…ule selector

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The PR adds documentation for board comment threads and the review rule selector. It describes thread counts, drawer contents and actions, selector configuration and behavior, and links to the selector documentation.

Changes: Board comments

Layer / File(s) Summary
Thread counts and comment actions
website/docs/apps/board.mdx
The documentation explains how row thread counts open the comments drawer. It describes displayed comments, available actions, write order, and per-thread errors.

Review rule selector

Layer / File(s) Summary
Selector behavior and discovery
website/docs/skills/rule-selector.mdx, website/docs/skills/index.mdx
The selector page documents stage bindings, fill formats, verdict handling, failure handling, and the default-off setting. The skills index links to the page.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to efdda

The documented board comment behavior and rule-selector workflow are consistent with the implementation and are ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies both primary documentation changes: the board comments drawer and the review rule selector.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

website/docs/apps/board.mdx

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 10.14.0

Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1929:14)
at Object..js (node:internal/modules/cjs/loader:2060:10)
at Module.load (node:internal/modules/cjs/loader:1651:32)
at Module._load (node:internal/modules/cjs/loader:1443:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:372:15)
at ModuleWrap. (node:internal/modules/esm/translators:244:9)
at ModuleJob.run (node:internal/modules/esm/module_job:561:25)
at async node:internal/modules/esm/loader:647:26

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d0a89ed8-4bb6-421f-be6e-1baf3e29811a
Commits

Reviewing files that changed from the base of the PR and between f7eb5fa and efddaf6.

Files selected for processing: 1
  • website/docs/apps/board.mdx

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread website/docs/apps/board.mdx Resolved
Comment thread website/docs/apps/board.mdx Resolved
…rd's own thread are left out

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@m4ttheweric

Copy link
Copy Markdown
Collaborator Author

Addressed in the latest commit: the section now says the count includes MR comments, and lists what the drawer and count leave out (bot comments, automatic links, author-and-bots-only threads, the board's own follow-up-review thread). The purity failure was a GitHub checkout timeout; rerun.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread website/docs/apps/board.mdx Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@m4ttheweric
m4ttheweric added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@m4ttheweric
m4ttheweric added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to Branch Protection failures Nov 3, 2026
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@m4ttheweric
m4ttheweric added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 63287cf Nov 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant