Repository navigation
overview: lane scroll bars, and Show in Workspaces (⌘O) - #25
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Show in Workspaces hands a pane from Overview's focused view to the canvas, and the old host's park arrived after the new host's attach, leaving the pane occluded: keys reached it but nothing redrew. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview's lanes scroll but hid their scroll bars, and turned back on they drew dark on a dark theme and over the cards. A pane opened full-size in Overview also had no way to jump to its own tab in Workspaces.
What changed
Lane scroll bars (
Sources/Flock/Views/MissionControl/).scrollIndicators(.never)from both lane scroll viewslaneScroller(theme:): the scroll view reaches into the lane's trailing padding so the bar runs beside the cardspanelBg, as popovers already doShow in Workspaces (
JumpNavigator,ViewCommand)jump(to:)Park on handoff (
SessionViewModel.performPark)Verification
Rendered
MissionLanesRenderTestsboth-large in tokyo-night and catppuccin-latte with scroll bars forced on: cards keep their place and overflowing lanes reserve the bar's width. The scroller's color was checked in Flock Dev, since offscreen captures do not draw it. NewtestShowInWorkspacesOpensTheFocusedPanesTabchecks the grid closes and herdr getstab.focusandpane.focus; palette and shortcut tests 27/27 green. NewtestAParkThatLandsWhileThePaneIsOnScreenLeavesItDrawing;SessionViewModelTests165/165. The park order was confirmed from a surface log in Flock Dev.🤖 Generated with Claude Code