Skip to content

overview: lane scroll bars, and Show in Workspaces (⌘O) - #25

Merged
m4ttheweric merged 4 commits into
mainfrom
lane-scrollbars
Oct 17, 2026
Merged

m4ttheweric merged 4 commits into
mainfrom
lane-scrollbars

Conversation

@m4ttheweric

@m4ttheweric m4ttheweric commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Overview's lanes scroll but hid their scroll bars, and turned back on they drew dark on a dark theme and over the cards. A pane opened full-size in Overview also had no way to jump to its own tab in Workspaces.

What changed

Lane scroll bars (Sources/Flock/Views/MissionControl/)

  • Drops .scrollIndicators(.never) from both lane scroll views
  • Adds laneScroller(theme:): the scroll view reaches into the lane's trailing padding so the bar runs beside the cards
  • Sets the scroll view's color scheme from the theme's panelBg, as popovers already do

Show in Workspaces (JumpNavigator, ViewCommand)

  • Adds Pane > Show in Workspaces (⌘O), enabled only while a pane is focused in Overview
  • Closes the grid and focuses the pane's tab, then the pane, through the existing jump(to:)
  • Lists it in the palette beside Back to Overview

Park on handoff (SessionViewModel.performPark)

  • Skips a park for a surface still in a window: the old host's park landed after the new host's attach and left the pane occluded, taking keys but not redrawing

Verification

Rendered MissionLanesRenderTests both-large in tokyo-night and catppuccin-latte with scroll bars forced on: cards keep their place and overflowing lanes reserve the bar's width. The scroller's color was checked in Flock Dev, since offscreen captures do not draw it. New testShowInWorkspacesOpensTheFocusedPanesTab checks the grid closes and herdr gets tab.focus and pane.focus; palette and shortcut tests 27/27 green. New testAParkThatLandsWhileThePaneIsOnScreenLeavesItDrawing; SessionViewModelTests 165/165. The park order was confirmed from a surface log in Flock Dev.

🤖 Generated with Claude Code

m4ttheweric and others added 2 commits October 17, 2026 09:03
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7b49e589-7795-4e71-b098-bc603c71f8f2
📥 Commits

Reviewing files that changed from the base of the PR and between 72ee0dc and 3b48a57.

📒 Files selected for processing: 3
  • Sources/Flock/Theme/ChromeMetrics.swift
  • Sources/Flock/Views/MissionControl/MissionControlView.swift
  • Sources/Flock/Views/MissionControl/MissionSplitLaneView.swift

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

Mission Control adds a theme-aware scroller gutter to subgroup lanes and uses the system’s default scroll-indicator behavior in the At Rest view.

Changes: Mission Control scroll indicators

Layer / File(s) Summary
Scroller gutter and indicator configuration
Sources/Flock/Theme/ChromeMetrics.swift, Sources/Flock/Views/MissionControl/MissionSplitLaneView.swift, Sources/Flock/Views/MissionControl/MissionControlView.swift
The subgroup lane content adds trailing padding for the scroller gutter. Its scroller uses the panel background to select a light or dark color scheme. The At Rest scroll view no longer explicitly hides indicators.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3b48a

The change is limited to scroll-indicator presentation, and the PR reports that cards retain their placement in rendering checks. No concrete merge-blocking behavior is identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: adding lane scroll bars in Overview. The supplied changes do not show a separate “Show in Workspaces (⌘O)” change, but the title remains substantially rel…
Full details: Title check

Explanation

The title clearly identifies the main change: adding lane scroll bars in Overview. The supplied changes do not show a separate “Show in Workspaces (⌘O)” change, but the title remains substantially related to the pull request.

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@m4ttheweric m4ttheweric changed the title overview: show lane scroll bars, beside the cards and drawn for the theme overview: lane scroll bars, and Show in Workspaces (⌘O) Oct 17, 2026
Show in Workspaces hands a pane from Overview's focused view to the
canvas, and the old host's park arrived after the new host's attach,
leaving the pane occluded: keys reached it but nothing redrew.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@m4ttheweric
m4ttheweric merged commit b75c422 into main Oct 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant