Integrate CodexKit products into CodexReviewKit - #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Move the Codex app-server and data products into CodexReviewKit so the SDK and its primary consumer share one repository, one package graph, and one revision. This removes the remote-pin/local-override split that allowed Xcode and SwiftPM to compile different CodexKit checkouts.
Changes
CodexAppServerKit,CodexAppServerKitTesting, andCodexDataKitfrom CodexKit commitab025ed970d30c7679913951bdb9fff20a9b77b1.enqueueAccountoverload that became ambiguous after the targets moved into the same package; the public overload remains unchanged.CodexDataKitproduct.Consumer migration
Consumers should change their Swift package URL and package identity from
CodexKittoCodexReviewKit. Existing imports and product names remain unchanged:CodexAppServerKitCodexAppServerKitTestingCodexDataKitThe standalone CodexKit repository can remain pinned at its final commit for older macOS deployments. It will be marked as moved and archived only after this integration lands.
Validation
swift test --build-system swiftbuild --no-parallelswift test --build-system swiftbuild --no-parallel --test-product CodexAppServerKitTests(405 tests)swift test --build-system swiftbuild --no-parallel --test-product CodexDataKitTests(346 tests)swift run --package-path Fixtures/CodexReviewKitProductConsumerxcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NOactionlintruby scripts/verify-github-actions-pinning.rbgit diff --check origin/main...HEADmain: 0 findingsNo screenshots are needed because this PR changes package ownership and build wiring without changing the rendered UI.