Skip to content

Separate API key sign-in into its own screen - #87

Merged
lynnswap merged 5 commits into
mainfrom
codex/sign-in-api-key-flow
Aug 9, 2026
Merged

Separate API key sign-in into its own screen#87
lynnswap merged 5 commits into
mainfrom
codex/sign-in-api-key-flow

Conversation

@lynnswap

@lynnswap lynnswap commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Purpose

Keep API key entry off the primary sign-in screen and present it as an explicit alternate authentication flow.

Changes

  • Replace the inline API key field with a Sign in another way action.
  • Add a dedicated API key screen with Cancel and Continue actions.
  • Preserve authentication cancellation and disable provider input while authentication is unavailable or in progress.
  • Add SwiftUI previews for both sign-in screens and stable accessibility identifiers for the new controls.
  • Update the resolved swift-log dependency pin.

Testing

  • swift test --build-system swiftbuild --no-parallel
  • Focused ReviewMonitorAddAccountActionTests
  • ReviewMonitor app tests during the Codex review gate
  • codex-review against main: no findings

Screenshots

Not included; Xcode previews are available for both Sign In and API Key Sign In states.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfe84f2672

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/ReviewUI/SignIn/SignInView.swift Outdated
Comment thread Sources/ReviewUI/SignIn/SignInView.swift Outdated

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970d0b7af3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/CodexReviewKit/Store/CodexReviewStore.swift

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: ee68c406ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap
lynnswap merged commit 36ec16c into main Aug 9, 2026
13 checks passed
@lynnswap
lynnswap deleted the codex/sign-in-api-key-flow branch August 9, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant