Harden SOPS editing edge cases - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause and impact
Several editing assumptions matched YAML object paths but not the actual SOPS CLI grammar or dotenv's flat data model. This could make valid dotenv edits fail late, target the wrong JSON key syntax, or fail when array lengths changed. The age recipient validator also predated native
age1pq1…recipients. Release packaging additionally hard-coded 1.0.0 and did not verify the advertised universal binary.The updated application validates these constraints before mutation, applies structured array patches safely through stdin, verifies the complete decrypted staging document as before, and refuses unsafe paths rather than guessing.
Validation
Scripts/test.sh— 83 passed, 0 failed, 0 skippedshellcheck Scripts/*.shactionlint .github/workflows/*.ymlScripts/package.shx86_64 arm64