deps: bump constants to v1.5.4 (drop LUX_ prefix from path env vars)#39
Merged
Conversation
Picks up luxfi/constants@v1.5.4 which renames the 4 binary-path env var values: LUX_NODE_PATH -> NODE_PATH, LUX_NETRUNNER_PATH -> NETRUNNER_PATH, LUX_EVM_PATH -> EVM_PATH, LUX_PLUGINS_DIR -> PLUGINS_DIR. Constant identifiers (EnvNodePath etc) unchanged — only doc strings in root.go / networkcmd/start.go / nodecmd/link.go need a textual refresh. BREAKING: external operators / scripts setting LUX_NODE_PATH (etc.) must rename to the un-prefixed form. Completes the LUX_ prefix sweep started in #38 — the 4 constants-defined names were left for this follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
luxfi/constantsto v1.5.4 (drop LUX_ prefix from binary path env vars constants#1) which renames the 4 binary-path env var values.cmd/root.go,cmd/networkcmd/start.go,cmd/nodecmd/link.goto reflect the new names.luxfi/constantsso were left for this follow-up.Renames
LUX_NODE_PATHNODE_PATHLUX_NETRUNNER_PATHNETRUNNER_PATHLUX_EVM_PATHEVM_PATHLUX_PLUGINS_DIRPLUGINS_DIRGo constant identifiers (
constants.EnvNodePathetc.) are unchanged — only the env var string values rename, so imports keep compiling without source-level edits.Breaking
LUX_NODE_PATH(etc.) must rename to the un-prefixed form. No fallback (per repo policy).Test plan
go build ./...cleango test ./pkg/binpaths/... ./cmd/networkcmd/... ./cmd/nodecmd/...cleanTestDerivefailure incmd/ammcmdis unrelated (verified on main).