[WRONG BRANCH] fix(cursor): preserve reserved-prefix call ids - #368
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(cursor): preserve reserved-prefix call ids#368luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ocxc1_-prefixed canonical base64url value even when the encoder would never produce it, which can change call identities on replay and corrupt pairing.Description
decodeCursorCallIdso it only accepts and decodes payloads whose decoded value actually requires encoding by addingif (!needsEncoding(decoded)) return id;insrc/adapters/cursor/call-id.ts.tests/cursor-call-id.test.tsthat asserts a canonicalocxc1_...id (e.g.ocxc1_Y2FsbF8x) passes through unchanged while multiline composite ids still round-trip.Testing
git diff --checkwhich produced no issues.bun test tests/cursor-call-id.test.tsand all 6 tests passed.bun run typecheckwhich succeeded.bun run test; the Cursor tests passed but the full run surfaced an unrelated failure intests/server-auth.test.ts(expected401, received403).Codex Task