Skip to content

[WRONG BRANCH] test: distinguish package files from directories #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
luvs01 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WRONG BRANCH] test: distinguish package files from directories #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions tests/repo-hygiene.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, expect, test } from "bun:test";
import { existsSync } from "node:fs";
import { existsSync, statSync } from "node:fs";
import { fileURLToPath } from "node:url";

const repoRoot = fileURLToPath(new URL("../", import.meta.url));
Expand Down Expand Up @@ -244,13 +244,19 @@ describe("devlog is tracked, with no submodule left behind", () => {
// end state, and a `toBeGreaterThan(0)` guard here would fail the suite for doing it.
const relative = [...readme.matchAll(/src="(?!https?:)([^"]+)"/g)].map((match) => match[1]!);

const missing = relative.filter((asset) => {
if (shipped.includes(asset)) return false;
// A directory entry ships everything beneath it. Decided by whether the tarball path is a
// prefix, not by whether the name contains a dot: `LICENSE` has no dot and is a file, and
// a future `assets` entry would have no dot and be a directory.
return !shipped.some((entry) => asset.startsWith(`${entry}/`));
const shippedDirectories = shipped.filter((entry) => {
const path = new URL(`../${entry}`, import.meta.url);
return existsSync(path) && statSync(path).isDirectory();
});
const isShipped = (asset: string): boolean =>
shipped.includes(asset) ||
shippedDirectories.some((directory) => asset.startsWith(`${directory}/`));

// Regular-file entries do not ship imaginary descendants.
expect(isShipped("assets/banner.png/missing.gif")).toBe(false);
expect(isShipped("LICENSE/missing.png")).toBe(false);

const missing = relative.filter((asset) => !isShipped(asset));
expect(missing).toEqual([]);
});
});
Loading