[WRONG BRANCH] fix(cursor): bind exec result guidance to exact tool identity - #365
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(cursor): bind exec result guidance to exact tool identity#365luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
isError:truestate.Description
CODEX_EXEC_BRIDGE_TOOL_NAMESand tightenisCodexExecBridgeToolto require either a bare recognized bridge name, the exactopencodex-responsesnamespace paired with a recognized name, or an exact MCP display-alias match such asmcp_opencodex-responses_<name>/mcp__opencodex-responses__<name>.isErrorvalue when emitting the empty-exec guidance so existing error states are not overwritten.tests/cursor-exec-empty-result.test.tscovering reserved-namespace exact matching, unrelated namespacedexecpass-through, alias matching, and error-state preservation.Testing
bun test tests/cursor-exec-empty-result.test.ts tests/cursor-toolresult-normalize.test.ts, and the changed/related tests passed (27 tests, all assertions succeeded).bun run typecheckandbun run privacy:scan; both checks passed for the scoped changes.bun run test) exercised many unrelated suites and exposed existing, unrelated timeouts/authentication-status mismatches; the focused Cursor regressions introduced here remain green.Codex Task