[WRONG BRANCH] fix: distinguish unmapped prompt layers from base prompt in probe and UI - #364
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix: distinguish unmapped prompt layers from base prompt in probe and UI#364luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
not-exposed, which caused the GUI to show a base-prompt-specific explanation for unrelated layers.Description
unmappedtoLayerTextand return it for the UNMAPPED_LAYER_IDS instead of reusingnot-exposed.not-exposedfor the actual base prompt which is confirmed to travel outside the printable message list.PromptLayerDialogto render a separatecodexSet.dialog.unmappedtranslation when a layer isunmapped.unmappedcopy across all supported locales and add two focused regression tests that assert the probe classification and the dialog text selection.Testing
bun run typecheck, which completed successfully.cd gui && bun test tests/codex-set-prompt-layers.test.tsx, which passed including the new regression (16 pass).cd gui && bun run lint:i18n,cd gui && bun run lint, andcd gui && bun run build, all of which succeeded (build produceddist/artifacts).bun test tests/codex-prompt-route.test.ts, which failed to initialize under the environment's Bun 1.2.14 due tonode:zlib.zstdDecompressSyncnot being available, so the route-level suite could not be fully executed here.cd gui && bun test tests), which exercised many tests and included the new changes, but the full run showed unrelated timer-based failures and initialization errors under the installed runtime; the focused tests and build remain green.Codex Task