[WRONG BRANCH] fix(cursor): persist and enforce tool-suspended checkpoint snapshots - #363
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(cursor): persist and enforce tool-suspended checkpoint snapshots#363luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
toolResultrequest may resume it.Description
toolSuspended?: booleanproperty toCursorCheckpointSnapshotand accepttoolSuspendedincommitCursorCheckpointso the suspension marker is persisted with snapshots.toolSuspendedfor commits that follow an external-model client tool call.resolveCursorCheckpointto reject snapshots whosetoolSuspendedis true unless the current request ends in atoolResult, while keeping the existingcheckpointUsablecompatibility check.toolSuspendedflag and validate that a ref-less ordinary retry is rejected (falls back tofull-replay) while a proper trailingtoolResultresumes the checkpoint.Testing
bun test --isolate tests/cursor-tool-suspended-checkpoint.test.ts, which passed (3 tests, 0 failures).bun run typecheck, which succeeded.bun run privacy:scan, which passed.bun run test; the focused Cursor tests passed but the repository-wide run surfaced unrelated existing failures/timeouts in other subsystems that are outside the scope of this change.Codex Task