Skip to content

[WRONG BRANCH] test(gui): verify feature navigation target - #362

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-feature-link-test-defect
Draft

[WRONG BRANCH] test(gui): verify feature navigation target#362
luvs01 wants to merge 1 commit into
mainfrom
codex/propose-fix-for-feature-link-test-defect

Conversation

@luvs01

@luvs01 luvs01 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The feature-gated row test was vacuous because it searched the whole row for .link-btn and matched an unrelated layer-name button, so it failed to guard the Open Features navigation affordance.

Description

  • Tighten the test in gui/tests/codex-set-prompt-layers.test.tsx to target the feature-note control (.codex-set-prompt__note .link-btn), click it with act(...), and assert the hash becomes #integrations/codex; the test name was updated to reflect routing verification.

Testing

  • Ran the focused test with cd gui && bun test tests/codex-set-prompt-layers.test.tsx and it passed (15 tests in that file).
  • Ran cd gui && bun run lint and cd gui && bun run build, both succeeded for the GUI; a full cd gui && bun test tests run exercised the suite but encountered unrelated environment failures (unavailable Bun/Node APIs and fake-timer helpers) that caused other tests to fail, unrelated to this test-only change.

Codex Task

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 52b1e98a-4f63-4b50-93dc-4f6a76053238


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title test(gui): verify feature navigation target [WRONG BRANCH] test(gui): verify feature navigation target Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev. UI screenshot required.

What to do

  • Retarget this PR to dev — all contributions go to dev.
  • Add a screenshot of the UI change to the PR description.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 28, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant