[WRONG BRANCH] security: restrict closed-PR branch cleanup to disposable namespaces - #361
Closed
luvs01 wants to merge 1 commit into
Closed
[WRONG BRANCH] security: restrict closed-PR branch cleanup to disposable namespaces#361luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
DISPOSABLE_BRANCH_PREFIXESand a new keep reasonOUTSIDE_DISPOSABLE_NAMESPACEto the planner so only branches in the reservedcodex/andingw/namespaces are eligible. (.github/scripts/closed-pr-branch-cleanup.cjs).planClosedPrBranchDeletionsto skip branches that do not start with an allowed disposable prefix and therefore never reach the deletion plan. (.github/scripts/closed-pr-branch-cleanup.cjs)..github/scripts/closed-pr-branch-cleanup.test.cjs).Testing
node --test .github/scripts/closed-pr-branch-cleanup.test.cjsand the planner unit tests passed (12/12)../node_modules/.bin/bun test tests/ci-workflows.test.ts tests/repo-hygiene.test.tsand the targeted workflow/hygiene suites passed (147/147).git diff --checkwith no issues detected.PATH="$PWD/node_modules/.bin:$PATH" bun run prepush(full prepush flow);typecheckand GUI lint passed, but the full test stage exposed unrelated environment-sensitive failures (lab sandbox / proxy env) that prevented completing the full suite in this environment (warning-level).Codex Task