[WRONG BRANCH] fix(responses): restrict canonical system-message folding to message items - #359
Closed
luvs01 wants to merge 1 commit into
Closed
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
role === "system"alone, allowing typed non-message items from provider output to be promoted into privileged top-level instructions and enabling cross-provider stored-prompt escalation.Description
isCanonicalForwardSystemMessagethat returns true only for plain objects whosetypeis absent or exactly"message"and whoseroleis"system", meaning only actual message items count as canonical system messages.normalizeCanonicalForwardPromptEnvelopefor both the collection pass and the removal/filter pass so the folding and strip operations only touch real message system items.does not promote a non-message item with a system roleintests/responses-forward-prompt-envelope.test.tsthat verifies anagent_messagewithrole: "system"is preserved as input while a legitimatemessagesystem item is folded intoinstructions.Testing
bun test tests/responses-forward-prompt-envelope.test.tsand the modified suite passed (5 tests, 0 failures).bun x tsc --noEmitandbun run privacy:scan, both of which succeeded.bun testrun in this environment produced unrelated, environment-sensitive failures; the focused regression test,typecheck, andprivacy:scanthat directly cover the change all passed.Codex Task