[WRONG BRANCH] fix(gui+server): reject out-of-range quota expiry timestamps - #356
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(gui+server): reject out-of-range quota expiry timestamps#356luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
expiresAtcould lie outside JavaScript's validDaterange and makeIntl.DateTimeFormat.format(new Date(...))throw, causing the Providers page to crash.Description
epochMillisreturnundefinedfor timestamps that do not produce a finiteDate(src/providers/quota.ts).expiresAtonly when it converts to a validDateand otherwise omit the optional expiry from the adaptedcreditsUsdshape (gui/src/provider-workspace/report.ts).currentPeriodEndin the quota probe and GUI rendering paths and a GUI rendering test that verifies an out-of-range expiry is omitted (tests/command-code-quota.test.ts,gui/tests/provider-capacity.test.ts,gui/tests/provider-capacity-credits.test.tsx).Testing
./node_modules/.bin/bun test tests/command-code-quota.test.ts, which passed (13 tests).cd gui && bun test tests/provider-capacity.test.ts tests/provider-capacity-credits.test.tsx, which passed (11 tests) and validated that out-of-range expiries are omitted and do not break rendering.cd gui && bun run build,bun run typecheck,bun run privacy:scan, andcd gui && bun run lint, all of which succeeded; the repository-widebun run testremains red due to unrelated pre-existing failures/timeouts and is not caused by this change.Codex Task