[WRONG BRANCH] fix(codex): restore collaboration prompt mapping - #352
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(codex): restore collaboration prompt mapping#352luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
collaboration_modetag mapping and classifiedcollaborationas permanently unmapped, which hid collaboration instructions when Codex actually rendered them.not-rendered, notnot-exposed, so the inspector must preserve the mapping.Description
collaboration: "collaboration_mode"entry inLAYER_SECTION_TAGSand removescollaborationfromUNMAPPED_LAYER_IDSinsrc/codex/prompt-text-probe.ts.mapSectionsToLayersand exports it asmapSectionsToLayersForTests, and updatesprobePromptTextto use that helper for mapping sections to layers.tests/codex-prompt-text-probe.test.tsthat asserts a rendered<collaboration_mode>maps to thecollaborationlayer with correct text/byte count and that an absent section maps tonot-rendered.Testing
bun test tests/codex-prompt-text-probe.test.ts; the focused probe tests passed (all assertions succeeded).bun run typecheck(bun x tsc --noEmit) which completed with no type errors.bun run test; the focused probe tests passed in that run, while some unrelated tests in this environment failed (these failures are orthogonal to the probe change).Codex Task