Skip to content

[WRONG BRANCH] fix(codex): restore collaboration prompt mapping - #352

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-collaboration-prompt-text-exposure
Draft

[WRONG BRANCH] fix(codex): restore collaboration prompt mapping#352
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-collaboration-prompt-text-exposure

Conversation

@luvs01

@luvs01 luvs01 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Motivation

  • A prior change removed the known collaboration_mode tag mapping and classified collaboration as permanently unmapped, which hid collaboration instructions when Codex actually rendered them.
  • Collaboration is a context-dependent config-toggle and an absent section should be reported as not-rendered, not not-exposed, so the inspector must preserve the mapping.

Description

  • Restores the collaboration: "collaboration_mode" entry in LAYER_SECTION_TAGS and removes collaboration from UNMAPPED_LAYER_IDS in src/codex/prompt-text-probe.ts.
  • Adds a focused projection helper mapSectionsToLayers and exports it as mapSectionsToLayersForTests, and updates probePromptText to use that helper for mapping sections to layers.
  • Adds regression coverage in tests/codex-prompt-text-probe.test.ts that asserts a rendered <collaboration_mode> maps to the collaboration layer with correct text/byte count and that an absent section maps to not-rendered.

Testing

  • Ran bun test tests/codex-prompt-text-probe.test.ts; the focused probe tests passed (all assertions succeeded).
  • Ran bun run typecheck (bun x tsc --noEmit) which completed with no type errors.
  • Executed the full test suite with bun run test; the focused probe tests passed in that run, while some unrelated tests in this environment failed (these failures are orthogonal to the probe change).

Codex Task

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 28, 2026
@github-actions github-actions Bot changed the title fix(codex): restore collaboration prompt mapping [WRONG BRANCH] fix(codex): restore collaboration prompt mapping Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 28, 2026 02:59
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant