[WRONG BRANCH] fix(claude): stop asserting IS_SANDBOX for root launches (preserve Claude root guard) - #350
Draft
luvs01 wants to merge 1 commit into
Draft
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IS_SANDBOX=1when launched as root with--dangerously-skip-permissions, which asserted a sandbox the process did not create and could bypass Claude Code's root guard.Description
IS_SANDBOX=1from OpenCodex: removed theallowRootSkipPermissionstest seam and the environment default that forcedIS_SANDBOXinto the spawned Claude process.IS_SANDBOXvalues are preserved.src/cli/claude.tsandtests/claude-cli.test.ts(small focused change preserving other behavior).Testing
node_modules/bun/bin/bun.exe test tests/claude-cli.test.tsand observed all Claude-focused tests pass (22 passing).bun x tsc --noEmit(typecheck) andbun scripts/privacy-scan.ts(privacy scan) and both succeeded.bun run testwhich exercised unrelated suites and reported existing, unrelated failures/timeouts; the change is scoped and the focused Claude tests and static checks passed.Codex Task