Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/server/responses/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { bridgeToResponsesSSE, buildResponseJSON, formatErrorResponse, type Resp
import { formatPassthroughUpstreamError } from "./passthrough-error";
import { describeUpstreamConnectFailure } from "./upstream-error";
import {
getConfigPath,
multiAgentGuidanceEnabled,
resolveEnvValue,
} from "../../config";
Expand Down Expand Up @@ -1688,7 +1687,7 @@ async function handleResponsesInner(
return formatErrorResponse(
400,
"invalid_request_error",
`${err.message}. Remove or reconfigure provider '${route.providerName}' in ${getConfigPath()}.`,
`${err.message}. Remove or reconfigure provider '${route.providerName}' in the OpenCodex configuration.`,
);
}
return formatErrorResponse(401, "authentication_error", err instanceof Error ? err.message : String(err));
Expand Down
33 changes: 33 additions & 0 deletions tests/oauth-status-privacy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { existsSync, mkdirSync, readdirSync, readFileSync, rmSync, writeFileSync
import { join } from "node:path";
import { getLoginStatus, getValidAccessToken, UnsupportedOAuthProviderError } from "../src/oauth";
import { saveCredential } from "../src/oauth/store";
import { handleResponses } from "../src/server/responses";
import type { OcxConfig } from "../src/types";

const TEST_DIR = join(import.meta.dir, ".tmp-oauth-status-privacy-test");
let previousOpencodexHome: string | undefined;
Expand Down Expand Up @@ -106,6 +108,37 @@ describe("OAuth status privacy", () => {
await expect(getValidAccessToken("removed-provider")).rejects.toBeInstanceOf(UnsupportedOAuthProviderError);
});

test("stale OAuth provider responses do not disclose the config path", async () => {
await saveCredential("removed-provider", {
access: "access-token",
refresh: "refresh-token",
expires: Date.now() + 60_000,
});
const config = {
defaultProvider: "removed-provider",
providers: {
"removed-provider": {
adapter: "openai-responses",
authMode: "oauth",
baseUrl: "https://provider.example/v1",
},
},
} as OcxConfig;

const response = await handleResponses(new Request("http://localhost/v1/responses", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ model: "test-model", input: "hello", stream: false }),
}), config, { model: "", provider: "" });
const body = await response.text();

expect(body).toContain("Unsupported OAuth provider");
expect(response.status).toBe(400);
expect(body).toContain("Remove or reconfigure provider 'removed-provider'");
expect(body).not.toContain(TEST_DIR);
expect(body).not.toContain("config.json");
});

test("malformed oauth token store is backed up before a new credential save overwrites it", async () => {
const authPath = join(TEST_DIR, "auth.json");
writeFileSync(authPath, "{not valid json", "utf8");
Expand Down
Loading