fix: add typesVersions fallback for clsx/lite (fixes #92) - #127
Open
3ni8ma wants to merge 2 commits into
Open
Conversation
Author
|
Before the fix, the same project failed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92.
Repro: TS project with moduleResolution node importing { clsx } from 'clsx/lite' fails with TS2307 before this change, passes after. bundler mode still passes.
Root cause: ./lite exposed only via exports map; classic node resolution ignores exports and looks for lite.d.ts at root.
Change: package.json adds typesVersions { *: { lite: [./clsx.d.ts] } }; readme notes bundler/nodenext/node16+ for full exports support.
Tests: npm run build + npm test green; tsc matrix node=pass, bundler=pass; CJS smoke clsx('hello', true && 'foo') => 'hello foo'. Trace snippet attached in comments.