ci: enable MSVC /RTCu runtime checks with dialog suppression#8
Open
ludomal wants to merge 9 commits into
Open
Conversation
ludomal
force-pushed
the
fix/windows-rtc-checks
branch
3 times, most recently
from
64b5496 to
e8a4906
Compare
- Add separate 'MSVC static analysis' CI job using /analyze flag Fails if C6001 (uninitialized variable use) warnings are found - Main Windows job builds in Debug mode with /RTCu runtime checks - Add src/utl/msvc_rtc_handler.c: custom RTC handler that prints to stderr and exits instead of showing popup dialog - Use STATIC library with /INCLUDE to force the handler into all executables Two complementary approaches: - /analyze catches issues at compile time regardless of test coverage - /RTCu catches issues at runtime when test data exercises the path
ludomal
force-pushed
the
fix/windows-rtc-checks
branch
from
e8a4906 to
e3e505d
Compare
added 5 commits
June 10, 2026 22:01
# Conflicts: # .github/workflows/ci.yml
- g728fpdec.c: init d->ogaindb=0 in decoder state (was read before first write) - is54/init.c: calloc for P array (malloc left it uninitialized, tainted Cl) - is54/lag.c: revert E init (not the cause; P was the issue) - wmc_tool/c_parser.cpp: memset Insert record before filling (String padding)
# Conflicts: # .github/workflows/ci.yml
ludomal
force-pushed
the
fix/windows-rtc-checks
branch
from
2d92c5e to
426a6da
Compare
added 3 commits
June 10, 2026 22:27
- is54/init.c: convert all malloc to calloc (zeroes all codec state arrays, preventing tainted data flowing into lag search) - wmc_tool/c_parser.cpp: initialize OperInsTbl.Data = NULL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable runtime detection of uninitialized variable use on Windows CI without popup dialogs.
Problem
MSVC Debug builds show modal popup dialogs when runtime checks (
/RTCu) detect uninitialized variable use. These popups block CI and are not caught by/we4700(compile-time only).Solution
src/utl/msvc_rtc_handler.c: installs a custom_RTC_SetErrorFuncWhandler that prints to stderr and exits instead of showing a popup. Also suppresses CRT debug dialogs and Windows Error Reporting.CMakeLists.txt: enables/RTCuin Debug builds and links the handler into all targets.Expected outcome
Any tool with uninitialized variable use at runtime will fail ctest with a clear error message instead of hanging on a popup.