DM-55564: Refactor FinalizeCharacterization tasks to reduce i/o#1335
Merged
Conversation
isullivan
approved these changes
Jul 22, 2026
isullivan
left a comment
isullivan
left a comment
Contributor
There was a problem hiding this comment.
Looks good, only a minor comment on a docstring.
| all_source_columns = handle.get(component='columns') | ||
| source_columns = [self.config.id_column, 'obj_index'] | ||
| # visit can be used if it is in the input catalog. | ||
| if visit is not None and visit in all_source_columns: |
Contributor
There was a problem hiding this comment.
Not really an issue since you're removing it, but how did this ever work before? Was it supposed to be 'visit' in all_source_columns:?
Contributor
Author
There was a problem hiding this comment.
All of that was to work around the way I wrote the tests originally and was too lazy to fix properly. Which I regret because it wasn't so hard to fix the tests after all, and this turned out to be unnecessarily hammering i/o.
erykoff
force-pushed
the
tickets/DM-55564
branch
from
July 22, 2026 18:09
2b45e39 to
1da586b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.