Closed
Conversation
Also make sure to use a consistent PSF size for preconvolution and decorrelation.
Otherwise the results are unstable when the science image has a psfSize of 2.0 in the unit tests and the template has a psfSize of 2.3 to 2.4. This change makes the basis a smooth transition instead of a sudden jump.
This does not suffer from the same bug as setting the image plane to 0 for masked pixels, since the peak is removed after detection.
The larger coverage fraction could actually sometimes succeed on x86 machines, leading to a test failure since it unexpectedly did not raise `NoWorkFound`. This change is necessary following the tightening of the template PSF size used in the tests, which changed the kernel behavior slightly.
Consolidate setting common values, but there should be no behavior changes.
Also remove the redundant calculation of the kernel source list in subtractImages - makeCandidateList was effectively called twice.
Use common code for both standard and Score versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.