DM-54540: bps report failed while reporting on a restarted task #88
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 84.79% 85.26% +0.46%
==========================================
Files 19 19
Lines 4263 4417 +154
Branches 458 463 +5
==========================================
+ Hits 3615 3766 +151
- Misses 570 575 +5
+ Partials 78 76 -2 ☔ View full report in Codecov by Harness. |
MichelleGower
left a comment
MichelleGower
left a comment
Contributor
There was a problem hiding this comment.
3 bps restarts have held jobs and 2 bps restarts if some succeed one first restart doesn't have correct counts (like previously reported problem but need 1 more restart).
mxk62
force-pushed
the
tickets/DM-54540
branch
3 times, most recently
from
July 13, 2026 23:57
8afd8c9 to
1b4296e
Compare
MichelleGower
approved these changes
Jul 14, 2026
MichelleGower
left a comment
MichelleGower
left a comment
Contributor
There was a problem hiding this comment.
Refactoring those pieces of code made it look much better in addition to fixing the problems. Merge approved.
A bug was causing mixing up condor_dagman job data with those related to DAGMan jobs if `dag.nodes.log` was missing. Fixed that.
During workflow restarts, selected files are being moved to a dedicated backup directory as HTCondor recreates them with the fresh content once a workflow is restarted. However, the backup function was also moving out such files for subdags that succeeded. HTCondor does not rerun DAGs that completed successfully. Their absence led to reporting incorrect job status counts as the information in these files is used by the plugin's reporting mechanism. Made changes to ensure that only files of the failed subdags are backed up.
_udpate_rescue_file() was trying to back up files for each failed subdags However, at the time of its execution these files were already backed up. Also, the function, in its current implementation, doesn't have access to the correct location of the backup directory. As a result it was creating an empty directory tree in the directory with the failed subdag. Modified it so it has a single responsibility -- updating the rescue file of the main DAG.
The function responsible for backing up files between restarts was using a very simple strategy to determine if files in a subdag directory needs a backup -- if a subdag directory contained a rescue file, the files were backed up. This strategy turned out to be too simplistic. It erroneously was backing up files for subdags that completed successfully after a restart as rescue files from previous failures were still present. To address this limitation, now the subdags that fails (if any) are being retrieved directly from the main DAG rescue file.
Contrary to the names of the methods in all other test cases, the names of the methods in the ReadSingleNodeStatusTestCase were using snake_case instead of camelCase. Fixed that.
Turned an entire 'Notes' section in a docstring to a regular paragrah in order to avoid a mysterious error from docutils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes