DM-55925: Skip optional parameters to Apdb.containsVisitDetector - #381
Merged
Merged
Conversation
In its latest re-implementation containsVisitDetector method does not need timestamp or region parameters and they were made optional recently. This patch removes these optional parameters from the call.
andy-slac
force-pushed
the
tickets/DM-55925
branch
from
September 12, 2026 19:32
20721f1 to
bcc2852
Compare
hsinfang
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In its latest re-implementation
containsVisitDetectormethod does not need timestamp or region parameters and they were made optional in the latest weekly release. This patch removes these optional parameters from the call.