DM-55342: Add concurrency to index updating - #115
Merged
Merged
Conversation
timj
reviewed
Jul 27, 2026
timj
left a comment
timj
left a comment
Member
There was a problem hiding this comment.
Looks okay but I'm worried that all the errors seem to be swallowed and everything reports that it all worked fine. Do the APIs correctly handle backoff retries?
Contributor
Author
|
|
timj
approved these changes
Jul 28, 2026
timj
left a comment
timj
left a comment
Member
There was a problem hiding this comment.
Thanks. Distinguishing errors from non-errors helps a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite script that builds index.json for eups.lsst.cloud. This implementation takes 90 secs vs 13 mins. And since this runs at least 2 times in release pipeline. We can save a lot of time and compute with these changes. We also added a dry-run function for testing.