fix: retry transport errors without misclassifying model text - #803
Open
Fwind43 wants to merge 2 commits into
Open
fix: retry transport errors without misclassifying model text#803Fwind43 wants to merge 2 commits into
Fwind43 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Short transport errors such as
!!!Error: ConnectionError: empty responsecould be mistaken for a final answer. Matching more text prefixes would instead misclassify legitimate model-generated text.What
LLMError(a string subclass preserving streaming/display compatibility).MockResponse.errorfor native and text-tool clients.Testing
python -m unittest discover -s tests: 11 tests pass.py_compilefor ga.py and llmcore.py;git diff --checkpasses.Supersedes the initial prefix-matching approach in this PR.