Support decimal-second timeout values - #2
Merged
Conversation
9 tasks
MarkusPaulsen
approved these changes
Sep 8, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutwith an explicitssuffixMotivation
Ares2 exposes resource timeouts in milliseconds, while Phobos previously treated the serialized integer as seconds. As a result, a timeout such as 2000 milliseconds could be executed as 2000 seconds.
The coordinated Ares2 change serializes millisecond values as canonical decimal seconds:
2000 msbecomes2.0001234 msbecomes1.234500 msbecomes0.500Phobos accepts that representation and passes it to GNU
timeoutas2.000s,1.234s, or0.500s.Compatibility
Existing native Phobos configurations using integer seconds remain valid. Zero and absent timeout values preserve their existing disabled behavior. Existing integer values are not heuristically reinterpreted as milliseconds.
Accepted configuration grammar:
Verification
bash -n core/phobos-common.shbash -n core/phobos-filesystem.shbash -n core/phobos_wrapper.shbash tests/timeout_units.shgit diff --checkCoordinated Ares2 change
The corresponding Ares2 serialization change is:
ls1intum/Ares2#175
The updated Phobos runtime must be available before the coordinated Ares2 behavior is released.