Switch Windows packaging from Nuitka to PyInstaller#3
Open
masonasons wants to merge 1 commit into
Open
Conversation
The Nuitka standalone build shipped an Add Source dialog whose OK/Cancel buttons were not visible — the frozen app rendered the dialog differently than running from source (a DPI/manifest difference in the freeze, not a bug in the dialog code, which lays out correctly from source and under PyInstaller). PyInstaller freezes the same code without that problem. While here, this also fixes native binaries never being bundled: Nuitka's --include-data-dir silently skips .dll/.exe files, so audio_hook32.dll, audio_hook64.dll, and injector32.exe never shipped and LegacyCapture was broken in every release. PyInstaller's --add-data copies them into native/dist/ where capture_legacy.py looks. - build.py: rewritten to drive PyInstaller (one-dir, windowed by default, --console for debugging); bundles data dirs, native binaries, and the packages PyInstaller's hooks miss. - CI: build with PyInstaller; artifact/release now from dist/PubStreamer/. - pyproject: swap the nuitka dev dep for pyinstaller. - README: document the PyInstaller build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Nuitka standalone build shipped an Add Source dialog whose OK/Cancel buttons were invisible. The frozen app rendered the dialog differently than running from source — running from source (and under PyInstaller) lays the dialog out correctly, so this is a freeze-time difference (DPI-awareness / manifest), not a bug in the dialog code. PyInstaller freezes the same code without the problem.
While switching, this also fixes a second latent bug: the native hook binaries were never bundled. Nuitka's
--include-data-dirsilently skips.dll/.exefiles, soaudio_hook32.dll,audio_hook64.dll, andinjector32.exenever shipped andLegacyCapturewas broken in every release. PyInstaller's--add-datacopies them intonative/dist/, wherecapture_legacy.pylooks for them.Changes
build.py— rewritten to drive PyInstaller (one-dir, windowed by default;--consolefor a debug build with tracebacks). Bundles the data dirs, the native binaries, and the packages PyInstaller's hooks don't fully discover on their own..github/workflows/build.yml) — build with PyInstaller; artifact and tagged release now come fromdist/PubStreamer/. Drops the Nuitka/MinGW cache steps.pyproject.toml— swap thenuitkadev dependency forpyinstaller.README.md— document the PyInstaller build.Notes
build_native.ps1) is unchanged and still runs first in CI so the hook binaries exist to bundle.main.dist/to PyInstaller'sdist/PubStreamer/(launcher atdist/PubStreamer/PubStreamer.exe, dependencies under_internal/).Built locally and verified: the app launches, the native binaries land in
_internal/native/dist/, and the Add Source dialog renders correctly with its buttons.🤖 Generated with Claude Code