Skip to content

docs: fix grammatical and logical bugs in VerilogCodingStyle.md#92

Merged
marnovandermaas merged 1 commit into
lowRISC:masterfrom
mondalsushant:fix/grammatical-and-logical-bugs
Jul 8, 2026
Merged

docs: fix grammatical and logical bugs in VerilogCodingStyle.md#92
marnovandermaas merged 1 commit into
lowRISC:masterfrom
mondalsushant:fix/grammatical-and-logical-bugs

Conversation

@mondalsushant

@mondalsushant mondalsushant commented May 20, 2026

Copy link
Copy Markdown
Contributor
  • Fix "With the exceptions of" -> "With the exception of"
  • Fix missing space before parenthesis in "UNIX-style line endings" rule
  • Fix period inside backtick: end. -> end.
  • Fix "Conversation" -> "Reason" in constants table header
  • Fix "symbolicly" -> "symbolically"
  • Fix "Examples;" -> "Examples:"
  • Fix "non-block" -> "non-blocking" assignments
  • Fix "recommened" -> "recommended"
  • Fix missing semicolon in code example
  • Fix missing closing parenthesis in good code example
  • Fix "and be implemented" -> "and must be implemented"
  • Fix "deferred to case statement" -> "deferred to the case statement"
  • Fix "identifed" -> "identified"
  • Fix "explanations examples" -> "explanations, examples"

@mondalsushant

Copy link
Copy Markdown
Contributor Author

Hi @rswarbrick and @marnovandermaas,

The changes are ready for inspection. Whenever you have some time, could you please take a look and review this PR?

Thank you!

@mondalsushant

Copy link
Copy Markdown
Contributor Author

@rswarbrick can you please have a look at this since I saw you are online. Thanks!

Comment thread VerilogCodingStyle.md Outdated
Comment thread VerilogCodingStyle.md Outdated
@mondalsushant
mondalsushant force-pushed the fix/grammatical-and-logical-bugs branch from 9a6630c to 144c302 Compare July 2, 2026 13:52
@mondalsushant
mondalsushant deleted the fix/grammatical-and-logical-bugs branch July 2, 2026 14:04
@mondalsushant
mondalsushant restored the fix/grammatical-and-logical-bugs branch July 2, 2026 14:10
@mondalsushant mondalsushant reopened this Jul 2, 2026
@mondalsushant
mondalsushant requested a review from rswarbrick July 2, 2026 14:17

@marnovandermaas marnovandermaas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, do you mind squashing your two commits?

@mondalsushant

Copy link
Copy Markdown
Contributor Author

Looks good to me, do you mind squashing your two commits?

Absolutely, give me an hour and I will do this.

@mondalsushant
mondalsushant force-pushed the fix/grammatical-and-logical-bugs branch from 144c302 to d84af80 Compare July 8, 2026 09:27
@mondalsushant

Copy link
Copy Markdown
Contributor Author

Looks good to me, do you mind squashing your two commits?

Squashed the two commits. The final commit is ready for an inspection.

@marnovandermaas
marnovandermaas merged commit 9c15ff5 into lowRISC:master Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants