Spit xbar into two levels#301
Open
elliotb-lowrisc wants to merge 1 commit into
Open
Conversation
elliotb-lowrisc
marked this pull request as ready for review
October 31, 2024 09:59
elliotb-lowrisc
marked this pull request as draft
October 31, 2024 10:00
elliotb-lowrisc
force-pushed
the
2xbar
branch
from
November 1, 2024 16:55
aa7d051 to
d2d8797
Compare
Contributor
Author
|
rebased onto draft pinmux changes |
elliotb-lowrisc
force-pushed
the
2xbar
branch
from
November 4, 2024 14:58
d2d8797 to
f5b35a4
Compare
Contributor
Author
|
rebased |
elliotb-lowrisc
marked this pull request as ready for review
November 4, 2024 14:59
HU90m
previously requested changes
Nov 4, 2024
| .tl_spi_ethmac_o (tl_spi_ethmac_o), | ||
| % for block in config.blocks: | ||
| % if not block.name == "gpio": | ||
| % if block.name not in ["gpio", "i2c", "spi"]: |
Contributor
There was a problem hiding this comment.
I think it may be nicer to add field to a block which states which crossbar it should be in. Instead of hard coding certain blocks in the templates.
Contributor
Author
There was a problem hiding this comment.
Fair enough, I've had a go. How does it look to you now?
elliotb-lowrisc
force-pushed
the
2xbar
branch
from
November 4, 2024 17:34
f5b35a4 to
0b3a015
Compare
elliotb-lowrisc
marked this pull request as draft
November 4, 2024 17:34
elliotb-lowrisc
force-pushed
the
2xbar
branch
from
November 4, 2024 17:37
0b3a015 to
99c2962
Compare
elliotb-lowrisc
marked this pull request as ready for review
November 4, 2024 17:39
elliotb-lowrisc
force-pushed
the
2xbar
branch
from
November 7, 2024 14:36
99c2962 to
fe713fc
Compare
Contributor
Author
|
rebase |
marnovandermaas
marked this pull request as draft
November 11, 2024 10:28
elliotb-lowrisc
marked this pull request as ready for review
November 11, 2024 11:24
elliotb-lowrisc
marked this pull request as draft
November 11, 2024 11:24
Attempt to reduce the depth of xbar logic on critical timing paths to/from the HyperRAM/SRAM by moving most peripherals from the main cross-bar to a new "peri" (peripheral) sub-crossbar. Keeps addresses the same, but some few devices have increased access latency due to being moved to xbar_peri or to improve QoR. Blocks with increased access latency: timer, system_info, & hw_rev. Blocks with decreased access latency: plic.
elliotb-lowrisc
dismissed
HU90m’s stale review
June 11, 2025 10:21
Have addressed HU90m's comments, but he is no longer around to approve them
Contributor
Author
|
Current utilisation (as I build it) is:
It also seemed to reduce the bitstream build time by several minutes for me. |
elliotb-lowrisc
marked this pull request as ready for review
June 11, 2025 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to reduce the depth of xbar logic on critical timing paths to/from the HyperRAM/SRAM by moving most peripherals from the main cross-bar to a new "peri" (peripheral) sub-crossbar. Keeps addresses the same, but some few devices have increased access latency due to being moved to xbar_peri or to improve QoR.
Blocks with increased access latency: timer, system_info, & hw_rev.
Blocks with decreased access latency: plic.
Seems to improve timing and area utilisation.