Updated to prevent unnecessary package version bindings#14
Conversation
joeblowma
commented
Jun 11, 2026
joeblowma
commented
- adjusted workflows to use build and a newer versions of python (untested)
- converted setup.py to pyproject.toml
- removed project dependency "setuptools", only required for building
- removed project dependency "onnxruntime" (fails for onnxruntime-gpu) in favor of a runtime import check
- added [cpu] and [gpu] options to README-EN.md
- version + 0.0.1
- adjusted workflows to use build and a newer versions of python (untested) - converted setup.py to pyproject.toml - removed project dependency "setuptools", only required for building - removed project dependency "onnxruntime" (fails for onnxruntime-gpu) in favor of a runtime import check - added [cpu] and [gpu] options to README-EN.md - version + 0.0.1
|
Not sure how I wound up with this installed, probably some old comfui node. It was causing dependency issues with pinning a really old version of setuptools as well as not recognizing that onnxruntime-gpu was installed. No more complaints about the package, the main .py now checks for onnxruntime on execution instead of making it an install requirement. The only other workaround I found for the onnxruntime was to install onnxrutime first, then install onnxruntime-gpu (which installs its content into the same onnxruntime folder) overtop. |
update workflows - reduce number of python targets in package, add an exclude for win/3.14 due to kaldi_native_fbank build failing - update to the latest actions, see if that solves some node warnings - deploy workflow is still untested
|
updated/corrected package workflow is now passing all test/lint builds. Publish (deploy) workflow updated as well using a fresh template and most recent action versions; remains untested. |
- failing in the build stage
|
Thank you for your contribution! |
2 participants
