feat: show users on login screens - #97
Open
BrandonItaly wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for displaying selectable users on the dashboard login screen by introducing a public users endpoint and a per-user “hide from login screens” policy flag, then wiring that through the SDK and dashboard UI.
Changes:
- Implement
/users/publicto return non-hidden users for login user selection. - Default the startup/admin user to hidden, and add a “Hide user from login screens” toggle to the user form.
- Add a login UI user-selection grid (with new CSS) and an SDK endpoint for fetching public users.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/remux-server/src/api/users.rs | Implements /users/public and filters users by policy.is_hidden. |
| crates/remux-server/src/api/startup.rs | Sets initial admin user policy to hidden during startup user creation. |
| crates/remux-sdks/src/remux/mod.rs | Adds GetPublicUsers endpoint to call /users/public. |
| crates/remux-dashboard/src/pages/users.rs | Adds user policy toggle to hide/show users on login screens; applies it on create/update. |
| crates/remux-dashboard/src/main.rs | Fetches public users and renders a selectable user grid on the login form. |
| crates/remux-dashboard/assets/theme.css | Styles the public user selection grid on the login page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lostb1t
reviewed
Jul 13, 2026
| )?; | ||
| user.is_admin = true; | ||
| let mut policy = crate::api::UserPolicy::default(); | ||
| policy.is_hidden = true; |
Owner
There was a problem hiding this comment.
is hidden is already true by default.
think we should make policy non optional for a user (struct) so its already there.
BrandonItaly
force-pushed
the
shows-users-login-screen
branch
from
July 15, 2026 07:14
2383e6e to
00b4b99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes users visible on login screens with the option to hide them