Skip to content

fix(research): prioritize native measurements and simplify source reading - #7254

Merged
loopx-agent merged 2 commits into
mainfrom
codex/native-measurement-reading-20261024
Oct 24, 2026
Merged

loopx-agent merged 2 commits into
mainfrom
codex/native-measurement-reading-20261024

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Goal and delivered outcome

Native measurements gave the first, best, retained and final result equal visual weight. Raw timestamps and repeated submission labels made the result hard to find, particularly on a phone. This maintainer-requested readability fix makes the best valid value in the captured window primary, with the other three roles as compact context. Unknown retention stays visibly unknown.

The Research entry, typed measurement projection and exact evidence reader remain the owners. Reading requires no additional confirmation or model call; the existing report navigation reaches the report in one action.

Author declaration

Written by: model_agent — Codex, OpenAI GPT-6 family.

Implemented against docs/development/design.md and frontend-delivery.md at 44050e953aa21f6deb932935fa158b5e415894c1, plus the existing trajectory_native_outcomes.ts contract.

Criterion Disposition Implementation / evidence
Attention hierarchy and explanations on demand implemented NativeResults: best first; full timestamps, method, digest and submission identity in one existing disclosure
Distinguish best, initial, last and actual retention implemented Unchanged typed point selection; seven real-owner browser cases include negative, zero, invalid, empty and partial windows
Original evidence, scope and unknowns stay readable implemented Exact citation callback and historical warning retained; partial-window qualifier visible
Populated page, narrow and expanded reading implemented Packaged history/report and native-reading scenarios; desktop, 390px and 200% text inspection

Scope and continuation

Complete within this presentation slice: result hierarchy, readable sources and focused regression coverage. This changes the default measurement layout for existing Research pages. It does not change scoring, stored values, retention, analysis requests, execution permission or source selection. Broader research interpretation and normal installed-App adoption remain in the existing delivery work; these browser captures do not establish them.

Bounded refactoring: applied one local value renderer for the existing four roles, preserving shared citation behavior. The new focused browser scenario reuses the existing real owner instead of adding another fixture backend. Larger research-page restructuring is outside this fix.

Validation

Tested UI source: ee911667cbe664d7cbf8a914ee076d766a048c64; final head 0090106a92a98407e868a1f1c42298f6e1ce26ec adds only its public screenshots and documentation. Run state: finished. Inputs: synthetic/public fixtures and authorized private read-only installed validation.

Kind Result Evidence / limit
static passed Dashboard tsc --noEmit, production Chat build, CSS custom-property checker, diff hygiene, bilingual RFC check; existing chunk-size warning remains
real_backend / real_entrypoint passed Packaged research-history and research-native-reading: real registration, typed projection, isolated SQLite and HTTP; original source unchanged and zero mutation attempts
unit passed Ten trajectory_native_outcomes.test.ts owner regressions
manual passed Default and expanded 1280×900 / 390×844, 200% long-unit layout, report and populated showcase composition; PNG pixels and metadata inspected
public boundary passed within scan Scanner's public-boundary result clean for all six text candidates. The broader registry command separately reports two unrelated canonical-state diagnostics; its total exit is not represented as passing
premerge passed automated; manual review completed Four direct checks, eight catalog, eight risk and one public-boundary check pass; exact-scope CQR valid. Raw gate remains manual_review_required for six PNGs: their synthetic pixels, source and metadata were individually inspected. This is not an automatic merge authorization
installed App passed, scoped Native App uses merged c10d8c2b4a20747e6eb77a188fd8e870b3be19de; runtime, research UI source and five served assets match. Existing authorized read-only source: best/final/unknown roles, full provenance, exact original citation and Escape return observed. Live details remain private; native narrow/stability not qualified
live model / benchmark not_run No model or experiment launched; synthetic public screenshots are distinct from installed readback

A first full history run exposed a premature focus assertion against the existing next-frame restoration. The test now waits for observable focus, then asserts the exact original trigger. Final full history passes. A concurrent test-server port collision was rerun on an isolated port. No production gate or assertion was removed. Remote CI is not queried under this delivery's review policy.

Frontend / visual evidence

Synthetic fixtures through the production packaged UI and real disposable backend. UI impact: changed. No public hosted preview; these are packaged captures. Before uses the existing equal-column capture; after uses the UI source above.

Default whole viewport — desktop

Before After
Before desktop After desktop

Default whole viewport — 390px

Before After
Before narrow After narrow

Best value now anchors the section; initial/final/retained recede without empty equal-width columns. Coverage, raw unit, direction and explicit UTC range remain visible. Full ISO times and repeated submission identity move to the existing sources disclosure. Historical and partial-capture qualifications stay visible with help closed.

Report reading and expanded sources

Results and report desktop
Selected report at 390px
Expanded sources desktop
Expanded sources at 390px

The narrow report capture is the existing one-step report reading position. Source captures use a separate signed-value fixture where best, final and retained differ; they are not a controlled score comparison. Expanded text uses the body token and wraps full identities. Keyboard/Escape returns to the exact evidence trigger; touch disclosure and Chinese/English help are covered.

Craft review: one result anchor, no new grouping card or decorative motion, visible unknowns and failures, document glyph for evidence, theme tokens throughout. Shared showcase desktop/narrow still presents its Goal outcome and work as the anchors. On a phone the ordinary report remains below the result section, reachable by its existing reading navigation; this PR does not claim all research content fits the first screen.

Change and area

  • Bug fix
  • Test and documentation update
  • Public presentation surface
  • Shared-authority RFC fixture impact: N/A; no authority or provider change.

Boundary checks

  • Public-safe source, fixtures, screenshots and description; no live/private state or raw traces.
  • No benchmark job, solver, scoring or submission behavior change.
  • Scoped to measurement reading; no English/Chinese RFC pair changed.
  • DCO on both commits; exact-head review and readiness remain separate merge gates.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机

研究页读者查看一段实验的原生测量结果。 原来需在四列和时间串中寻找最佳值;现在先看到本次窗口最佳,再按需查看首次、最后、保留及完整来源。 打包页面已突出最佳值,保留未知与负值,证据和原始身份仍可直接回看。 本PR不改变评分、保留策略、模型调用、权限或求解执行,也不证明已安装App采用。 正式App安装采用与更广的研究分析交付继续沿原有工作推进。

读者原先必须先读完时间串、四个同样显眼的数值和重复的提交编号,再判断哪个是本次窗口内的最佳结果。只有把信息折叠而不建立主次,仍不能解决这个问题。本次可独立交付的结果是明确最佳值的阅读锚点,同时将实际保留、最后提交和首次提交继续分开。这里的最佳结果只描述所捕获的窗口,不替代实际采用或目标达成的判断。

改动思路

现有typed投影和引用回调足以承载本次布局,展示层不重算最佳或保留,也不新增配置、状态库和权限。 本PR仅交付原生测量阅读层级、来源展开及其真实打包验证;原生App采用和更广研究分析留在既有工作。

我比较了不改、只放大所有数值、在原组件改层级以及另建结果页面四条路径。前两条保留了同等视觉权重,另建页面增加导航和归属成本,现有组件内的调整足够。入口仍是 ResearchProgress,权威输入仍是既有原生测量投影;NativeResults 用准确的点键取值,只负责阅读布局。点击文档图标继续把原引用和触发按钮交给既有证据阅读器,Escape 回到同一个按钮。首次阅读没有新增填表、复制、提问或确认;自愿查看完整来源或跳到报告各用现有的一次操作。

读取内容 原布局 当前布局
窗口内最佳有效值 四个同等列之一 主值和原单位
首次、最后、实际保留 各占一列并重复提交编号 紧凑辅助值;未知保留仍未知
时间和来源身份 默认显示完整时间串 UTC简要窗口;完整ISO、方法、身份在原展开入口

这个表解释已检查的源码与截图;它不替代后端或交互验证。新增局部 value 渲染函数复用四类既有点的引用行为,没有创造新的值选择规则。测试也复用 startHistoryOwner,避免为了验证页面再造一套假后端。

具体改动

评审依据:docs/development/design.md,固定版本 44050e953aa21f6deb932935fa158b5e415894c1。逐条映射:Earn The User's Attention implemented,原生主值突出而未知和有效覆盖仍可见;Research Workspace / 研究工作台 implemented,仍在原Goal研究入口读取同一来源,查看引用不启动分析;Populated Page Review implemented,检查了默认、完整来源、报告、长单位及稀疏/无效/历史状态的桌面和窄屏。这里没有把更广的科研正确性或已安装采用缩减成截图通过。

关键代码讲解

  1. NativeResults 保留 existing best_valid、initial、final_valid、retained 四个点的身份。读取顺序和排版改变,但实际保留不从最佳或最后值推导;point对象为空时显示未知,因此零与负数不会被误当作缺失。捕获时间默认以明确UTC显示,完整时间和提交编号仍在来源展开中。
  2. ResearchProgress 的既有调用关系仍在:有原生投影才渲染测量,RetainedImprovement 继续负责独立的采用增量判断。普通报告和完整历程保持自己的入口,不将最佳值升级成接受成果。配套CSS使用主题字号,主值32px、辅助值16px、展开正文14px,44px按钮和focus反馈保留。
  3. researchNativeReadingScenario 通过实际注册、typed投影、独立SQLite和HTTP走产品读回。七个预先指定预期的案例覆盖高/低优方向、负数、零、无效首次、全部无效、空样本、部分前缀与长单位,特别验证最佳-3、最后-2与保留-1不能互相替代。原history场景继续检查来源切换、历史警告、报告和证据返回;目录注册只增加此实际消费者。

整个diff是两处产品展示文件、三处场景注册/验证路径,以及来源文档和六张合成截图。已逐张查看图片像素和元数据,截图没有私人运行内容或文本/EXIF块。说明文档明确固定UI源码、数据与打包边界,窄屏报告截图标为一次导航后的阅读位置。

对主干的风险

最强的反例是突出“最佳”后让读者误认为“已采用”,或者把零、负值、缺失与历史结果混同。当前实现继续读取同一typed owner,基准到head的原生投影及后端目录没有diff;独立有符号案例、未知保留、部分窗口及原history历史状态通过。当前和历史警告保留,完整来源含身份与时间,文档图标也避免暗示走势。没有新的权限、生命周期、模型提示、状态迁移、调度或配额规则;这是明确披露的默认布局调整,不声称可选开关关闭后的新能力隔离。

实际验证包括Dashboard类型检查、生产Chat构建、CSS检查、10项原生owner回归、完整打包history、七类native读回与showcase。标准premerge四个直接检查及17个选中检查通过,CQR cqr_05f5f45c2321c64e99bd 对准确12路径有效。原始premerge仍因六张图返回manual_review_required;本次已在准确head评审中逐一核对像素、合成来源和无嵌入文本/EXIF,没有把自动门伪报为全绿。

保留先前失败:原history中的即时focus断言可能早于已有下一帧恢复,现在等待可观察焦点后仍断言准确触发元素;最后完整用例通过,没有删断言或更改产品恢复逻辑。并发测试端口冲突改为独立端口顺序运行。全局registry检查另有两个不属于此diff的规范状态诊断,公共边界子检查为clean;标准premerge自己的公共检查通过。既有bundle大小警告保留。按本Goal现行wait_for_ci=false,未读取、轮询或等待远端CI。

我的整体评价

交付判断为 justified_increment:本次原生测量层级已经形成可读、可逆并有真实后端支撑的结果,未据此关闭原研究工作。长程影响 preserved,原数据与后续继续路径保持;用户体验 improved 限于已观察的阅读构图和交互,不将其解释为统计上的理解收益。默认布局的变化已披露,原生值、完整来源和引用语义保留;局部既有点集合没有新增共享词汇,语义对齐检查未发现状态或协议扩展。

已逐张检查默认、完整来源和报告桌面/窄屏:最佳值形成主锚点,辅助值紧凑;方法与哈希退入正文大小的来源展开,完整时间和未知仍可读。 未验证正常已安装App采用、原生WebView交互或真实用户理解收益;合成提供器不证明科研判断准确。

另检查了报告手机阅读位置、完整来源下半部和共享showcase:主值与技术身份现在可分层读,展开后没有靠缩小文字隐藏内容。手机默认仍先显示测量,报告可从既有导航一次到达,不宣称全部内容都在首屏。兼容分支、第二权威owner或新产品模块没有必要;本次局部复用足够。当前PR边界可接受,未发现阻塞性问题;合并仍需最新head、现行ready读回和既有维护者授权,正常App采用必须在后续原入口实测。

English verdict: APPROVE — reviewed 0090106a92a98407e868a1f1c42298f6e1ce26ec. The best-in-capture value is primary while initial, final, retained, unknown and exact evidence identities remain distinct. Local type/build, real SQLite/HTTP packaged journeys, negative role cases and risk-based premerge checks pass; six synthetic-image holds were manually inspected. No remote CI was queried. Installed-App adoption and scientific/user-comprehension benefit remain unverified. This author-owned COMMENTED conclusion is not formal self-approval or merge authority.

@loopx-agent
loopx-agent merged commit c10d8c2 into main Oct 24, 2026
10 of 12 checks passed
@loopx-agent
loopx-agent deleted the codex/native-measurement-reading-20261024 branch October 24, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant