Warn on RTE-widened models and fix false ARXML/A2L desyncs - #35
Merged
Conversation
…false ARXML desyncs A quick single-model regen that gains an RTE access point cannot be integrated on its own -- the RTE layer and the peer SWCs have to be regenerated too. A peer model whose C stayed identical is the proof the batch skipped them: a real regenerate rewrites at least a timestamp banner everywhere. The ARXML/A2L advisory now triggers on a parsed access-point move instead of the file's verdict. Shared library packages (base types, compu-methods, units) are rewritten on every export and were raising false desync warnings. A file that could not be parsed that far still warns -- unprovable is never noise. Both advisories now also render in the viewer, bottom-left under the quick-changes panel, off the same seam the report and the CLI use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consistency_advisories()seam the report and the CLI already use — one source of truth across all three surfaces.Why
A regenerated model that only widens its RTE interface still needs the AUTOSAR architecture regenerated before the code integrates; nothing in the tool said so before this. Separately, the existing ARXML/A2L advisory was keyed on the file's diff verdict, so routine library churn (base types, compu-methods) was raising false alarms — reported by the user as a real false-positive in their workflow.
Test plan
python -m unittest discover -s tests— 715 tests pass (headless + Qt viaQT_QPA_PLATFORM=offscreen)python -m ruff check .— cleantests/fixtures/demoand confirmed both advisories fire with the expected messages