docs: C two-pass compare diagram in architecture.md - #34
Merged
Conversation
The 'data flow of one compare' sequence diagram compressed the whole compare into three abstract 'pass 1 / pass 2 / label' lines. Replace it with a flowchart that follows two C files end to end: the scanner dispatch (added/deleted/error/ both), the early exits, the C shadow, PASS 2, the three noise filters that each peel off only what they can prove (rename map, autogen-name, reorder), moved- block detection, PASS 1 labelling, and the single _status_of verdict. Light node fills so it reads in GitHub's light and dark themes alike.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the abstract data flow of one compare sequence diagram with a flowchart that follows two C files end to end.
The old diagram flattened the compare into three lines (
pass 1 / pass 2 / label). The new one shows the whole path: scanner dispatch (added / deleted / error / both), the early exits, the C shadow, PASS 2, the three noise filters that each peel off only what they can prove — rename map, autogen-name, and the new reorder step — moved-block detection, PASS 1 labelling, and the single_status_ofverdict.Light node fills so it renders in GitHub's light and dark themes alike. ARXML/A2L follow the same two passes with their own shadow.
Docs only — no code change.