plot: Polish hover crosshair color and fix horizontal bar band#2513
Merged
Conversation
- Darken the dashed crosshair by blending `border` toward `foreground`, so it reads a touch deeper than the (border-colored) grid lines in both light and dark themes. - Fix the horizontal bar hover band overflowing the value axis: it called `.span()` (which sets the vertical span) after `.horizontal()`, so the horizontal line fell back to `w_full()`. Use `.h_span()` to confine the band to the bar region. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
madcodelife
force-pushed
the
plot-hover-crosshair-and-bar-band
branch
from
c4a0a31 to
8bb795a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bordertowardforeground, so it reads a touch deeper than the (border-colored) grid lines in both light and dark themes..span()(which sets the vertical span) after.horizontal(), so the horizontal line fell back tow_full(). Use.h_span()to confine the band to the bar region.