ux/qol audit sweep: data-correctness fixes, consistency, and QOL#285
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings and fixes from a full walkthrough of the app (all pages), grouped as data-correctness bugs (P0), UI consistency (P1) and quality-of-life (P2). Frontend changes were validated with
svelte-check(no new errors beyond the known baseline); backend changes ship with tests.Data correctness (P0)
dashboardService.getStatsread "today" from the hourly continuous aggregate for everything but the last hour. When the aggregate is not kept warm (refresh policy not running, seeded/backfilled data, fresh install) the older part of today is missing, so the total and error rate silently dropped to ~the last hour (verified live: 24h ≈ 1,500 logs, last hour ≈ 67, card showed ~60 / 0.0%). Low-volume orgs now count today/yesterday from an exact raw count; high-volume keeps the fast aggregate path.node:runtime frames were treated as app code, so their variation across async stacks leaked into the fingerprint (oneselectFromTypeError fanned into 5+ groups).node:frames are now library code and excluded from the fingerprint.logstable, which is empty on non-TimescaleDB engines. The service is now carried on theexceptionsrow (migration 054) and the trigger prefers it.Consistency (P1)
TimeRangeButtonscomponent.<select>s replaced with the sharedSelect; Metrics Explorer duplicate project/time-range controls removed; Members date format made consistent; Projects tab title fixed.Quality of life (P2)
Notes