Skip to content

Update LUI Composer layout with compatible Signal - #61

Merged
RCmerci merged 2 commits into
mainfrom
codex/lui-composer-center-20261010
Oct 10, 2026
Merged

RCmerci merged 2 commits into
mainfrom
codex/lui-composer-center-20261010

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Journal's earlier LUI pin predates the merged Composer centering change. Update both dependency manifests to merged LUI c0b007ff80eea8934b75e631b59b4f0609bb4c72 and its matching merged Signal 02e18cdc5e0ad672aa223f638eaa3ba52fc9421e, and enforce both exact revisions in the existing dependency boundary check. Empty and single-line Composer text retains its intrinsic height centered inside the 36pt input row; multiline text continues growing within its 168pt cap, above separate attachments and controls.

logseq/ocaml-signal#9 restores the synchronous nested drain required by LUI navigation to publish queued owner writes before checking a native host event's revision. The original navigation / queued owner write versus stale host event assertion is unchanged: the earlier LUI42fee/Signal877 pair fails it, while the matched merged pair passes. The standalone public-interface probe likewise changes from RED to GREEN. The earlier RED evidence is preserved outside the repository.

No direct Journal implementation or API adaptation is required. Datascript remains pinned to 0561660e4894faee250d551ab2a32a6b5c25a5fb.

Validation:

  • Exact unmodified upstream source archives: LUI 434 files and Signal 17 files verified against their archives. LUI OCaml install and iOS Simulator Swift static-library builds passed.
  • Full LUI regression suite passed (105 tests), including all 9 navigation tests. Full Signal regression suite passed, including 38 Alcotest cases, 19 property tests, and runtime/lifecycle probes.
  • Full Journal build (@all and app/native_embed.exe.o) and dune runtest --force passed, including 74 Application tests and the updated dependency boundary check.
  • Seven actual-click acceptance tests passed (0 failures, 201.441s) on the dedicated iPhone 13 / iOS 26.1 Simulator through production Application/native adapters with an independent synthetic service: Timeline and Detail at 320pt/390pt, empty/single-line centering, multiline bounded growth, keyboard clearance, cancel/reopen, native attachments, last-child Send, and failed-import retry. The 320pt cases use a fixed native content viewport on the 390pt Simulator.
  • Task-owned OCaml, Swift, Journal, and acceptance-runner caches were reused. The Simulator fixture links the exact merged Signal/LUI libraries, and its installed binary hash matches the rebuilt app. No global pins, Dune files, production workarounds, user accounts, graphs, or phone installs were changed.

Journal CI passed on head 00e25fb32562b6174ae88a5907a94b45d26437a2. Its uploaded dependency evidence resolves exactly LUI c0b007ff, Signal 02e18cdc, and Datascript 0561660e.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T11:33:43.200855Z d794769 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci RCmerci changed the title Update LUI for centered Composer input Update LUI Composer layout with compatible Signal Oct 10, 2026
@RCmerci
RCmerci merged commit 1cbb925 into main Oct 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant