Repository navigation
fix: honor native index node reference policy - #45
Merged
Merged
Conversation
Preserve persisted Weak and explicit Strong policies when restoring native storage-backed indexes. Cover node collection and reload behavior with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native storage restore overrides persisted
Weakindex references withStrong, keeping every visited PSS node reachable for the database lifetime. Scanning a graph can therefore retain the decoded index in memory even after indexing finishes.Disable the native override so restore honors the persisted reference policy, matching the other runtimes. Explicit
Strongsettings remain supported. Add a regression test that checks both policies and verifies that collected weak nodes reload correctly after a major GC.Validation passed:
opam exec -- dune exec test/test_storage.exe,opam exec -- dune exec test/test_conn.exe, andopam exec -- dune runtest(including native/JS/upstream SQLite parity). Optional local-graph smoke checks were skipped because their fixtures were unavailable.Weak caching can increase storage reads after major collections; this change restores the requested cache policy rather than retaining all visited nodes indefinitely. The separate Logseq storage-payload cache fix is outside this PR.