Repository navigation
pin persistent-sorted-set-ocaml to merged main SHA - #43
Merged
Merged
Conversation
The perf/add-insert-fast-path PR was squash-merged upstream; point pin-depends at the merge result on main (identical tree content as the previously pinned branch tip).
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points
pin-dependsforpersistent_sorted_set_ocamlat the squash-merged result on upstreammain(634fc5e), instead of theperf/add-insert-fast-pathbranch tip (b4c97e3) that PR #42 referenced. Tree content is identical — this only moves the pin onto a commit that lives on main so future installs resolve a stable ref.Verified: pin reinstalled at the new SHA and the full
dune runtestgate is green.Link to Devin session: https://app.devin.ai/sessions/a699c982a95844238c1dcd1ff6cc8d5d
Open in Devin Desktop: https://app.devin.ai/desktop/session/a699c982a95844238c1dcd1ff6cc8d5d?variant=devin
Requested by: @tiensonqin