Repository navigation
Migrate alignment integration tests to use fixtures across adapters - #128
Open
CorinChappy wants to merge 1 commit into
Open
CorinChappy wants to merge 1 commit into
CorinChappy wants to merge 1 commit into
Conversation
This provides better reporting for assertion errors and IDE support for test running
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A critical event-loop pool issue and a moderate cleanup-table issue remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Migrates projection adapter integration tests to shared fixtures across in-memory and PostgreSQL adapters.
Changes:
- Adds parametrized adapter harnesses and fixtures.
- Removes duplicated adapter tests.
- Standardizes async fixture and pool lifecycle management.
| File | Summary |
|---|---|
tests/unit/logicblocks/event/projection/store/adapters/test_memory.py |
Removes superseded memory adapter tests. |
tests/shared/logicblocks/event/testsupport/db.py |
Updates pool lifecycle management. |
tests/shared/logicblocks/event/testcases/projection/store/harnesses.py |
Moderate (4 votes): clear_storage() truncates events instead of projections. |
tests/integration/logicblocks/event/store/adapters/test_postgres.py |
Updates async fixtures. |
tests/integration/logicblocks/event/projection/store/adapters/test_postgres.py |
Removes duplicated PostgreSQL tests. |
tests/integration/logicblocks/event/projection/store/adapters/test_adapters.py |
Uses parametrized harness fixtures. |
tests/integration/logicblocks/event/projection/store/adapters/conftest.py |
Critical (3 votes): Session-scoped pool may be reused across incompatible event loops. |
tests/integration/logicblocks/event/processing/broker/strategies/distributed/test_broker.py |
Updates async fixtures. |
tests/integration/logicblocks/event/processing/broker/strategies/distributed/subscriptions/stores/state/test_postgres.py |
Updates async fixtures. |
tests/integration/logicblocks/event/processing/broker/strategies/distributed/subscribers/stores/state/test_postgres.py |
Updates async fixtures. |
tests/component/test_processing.py |
Updates async fixtures. |
tests/component/test_asynchronous_projections.py |
Updates async fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ) | ||
|
|
||
|
|
||
| @pytest_asyncio.fixture(scope="session", loop_scope="session") |
Comment on lines
+42
to
+43
| async def clear_storage(self) -> None: | ||
| await clear_table(self.pool, "events") |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides better reporting for assertion errors and IDE support for test running