Repository navigation
Use awarning instead of deprecated awarn - #126
Merged
Merged
Conversation
structlog's awarn is a deprecated alias for awarning and is absent from structlog.stdlib.BoundLogger, the wrapper class used when integrating structlog with the standard library's logging module. The logger these call sites use is resolved at bind time from the host application's global structlog configuration, so the library cannot rely on FilteringBoundLogger-only members being present. In store.py the call sits inside an except UnmetWriteConditionError handler, so a missing attribute raises AttributeError while that exception is being handled and replaces it, causing callers' except UnmetWriteConditionError handlers to silently stop matching. awarning is present on every wrapper class and is otherwise identical.
tobyclemson
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structlog'sawarnis a deprecated alias forawarningand is absent fromstructlog.stdlib.BoundLogger, the wrapper class used when integrating structlog with the standard library'sloggingmodule.The logger at these call sites is resolved at bind time from the host application's global structlog configuration, so the library can't rely on
FilteringBoundLogger-only members being present.In
store.pythe call sits inside anexcept UnmetWriteConditionErrorhandler, so the missing attribute raisesAttributeErrorwhile that exception is being handled and replaces it — callers'except UnmetWriteConditionErrorhandlers silently stop matching. Found via a redelivery path in a downstream service, where a duplicate guard stopped catching and wedged the subscriber.awarningis present on every wrapper class and is otherwise identical: same level, same output.