Remove several deprecated functions#650
Open
sschulz92 wants to merge 2 commits into
Open
Conversation
fgdrf
reviewed
Dec 15, 2021
Comment on lines
-248
to
-266
| * @return <code>true</code> if layer is selectable, <code>false</code> otherwise. | ||
| * @deprecated use getInteraction(Interaction.SELECT) | ||
| */ | ||
| @Deprecated | ||
| public boolean isSelectable(); | ||
|
|
||
| /** | ||
| * Sets the value of the '{@link org.locationtech.udig.project.internal.Layer#isSelectable | ||
| * <em>Selectable</em>}' attribute. <!-- begin-user-doc --> Used by the user to control which | ||
| * layers are selectable, may be ignored for GeoResources that do not support editing. <!-- | ||
| * end-user-doc --> | ||
| * | ||
| * @param value the new value of the '<em>Selectable</em>' attribute. | ||
| * @see #isSelectable() | ||
| * @deprecated use setInteraction(Interaction.SELECT, value) | ||
| */ | ||
| @Deprecated | ||
| void setSelectable(boolean value); | ||
|
|
Contributor
There was a problem hiding this comment.
these interface methods are generated from the model. I guess its necessary to remove these from EMF model and re-generate code usin EMF Toolset within Eclipse.
Maybe @egouge can support here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within this PR I want to remove the following functions from the interface
ILayerwhich are deprecated for quite a while:public boolean isSelectable();void setSelectable(boolean value);CoordinateReferenceSystem getCRS(IProgressMonitor monitor);