Repository navigation
chore(tsconfig): drop baseUrl and list types explicitly for TypeScript 6 - #99
Merged
Merged
Conversation
TypeScript 6 deprecates baseUrl (TS5101) and defaults `types` to [], so @types/node and @types/jest are no longer picked up automatically. Make the @clack/prompts path mapping relative and list the types. Both changes work on TypeScript 5.9 too, which unblocks #61. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prepares
tsconfig.jsonfor TypeScript 6 so #61 (TypeScript 5.9.3 → 6.0.3) can pass CI. The config works on both versions.baseUrl: TypeScript 6 deprecates it, andtscfails with TS5101.pathshas resolved relative to the tsconfig since TypeScript 4.1, so the mapping only needs a./prefix.types: TypeScript 6 defaults it to[], so@types/nodeand@types/jestare no longer included automatically. Without listing them,describe,jestand similar are unknown, and all Jest suites fail because ts-jest type-checks too.Evidence
Merge Danger
Door: two-way
Blast Radius: type-check only
This only changes type-checking:
xmcp buildskips type checks, and esbuild usestsconfig.cli.json, which resetspaths. After this merges, comment@dependabot rebaseon #61.🤖 Generated with Claude Code