Repository navigation
Conversation
AGENTS.md records the design rules for the MCP servers (compute in LocalStack, public interfaces only) and the approved client-side exceptions, starting with grouping App Inspector failed requests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… with main Adds REVIEW.md §0 (secret leaks through CI, external and Dependabot PRs), dependency pinning for Dependabot, Docker image size, and testing rules for MCP tools. Known deviations now cover existing code on main only; the IAM actions are documented as design and the agentic eval as a follow-up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace counts, versions, port ranges and field lists with rules and pointers to the source, and add "Maintaining this file": lists the code can check belong in ratchet tests, deviations are described by pattern. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…fo, endpoint proposal) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… payload fields, deviations intro) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eptions home) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…endency sources) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ions by pattern) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…analytics allowlist) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed pins) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mage size on bumps) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…udit scope) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… to the change, testable escaping) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Agents and reviewers working on this server had no written design rules. Several patterns in the code also go against where the project is heading: the legacy
localstackCLI,awslocal-style wrappers, parsing logs, private LocalStack internals, and computing in the client what LocalStack should decide. This PR writes the rules down so new code follows them, and lists where existing code doesn't yet.Solution
AGENTS.md(withCLAUDE.mdpointing to it): commands, layout, how to write a tool, and the design rules.localstack-app-inspector(not implemented here).REVIEW.md: the rules as review checks with severities. §0 makes leaking secrets through CI a BLOCKER, with checks for external-collaborator and Dependabot PRs.mainonly. New code follows the rules. A change that needs to break one raises it first, and a change that touches a listed deviation says what it did about it.AGENTS.md. Lists the code can check belong in ratchet tests (a follow-up PR), and deviations are described by pattern.Adversarial review
Ten rounds of adversarial review checked both files against this branch's code, lstk, the LocalStack specs and the public docs. The last round found no blockers. Decisions still open, recorded in the files:
/_localstack/licenseinfois listed as a known deviation until LocalStack documents a way to check licensed features.Review
Advise review: these files set rules for every future change, and they contain decisions (endpoint scoping, container names, the IAM design) that the team should agree on.
🤖 Generated with Claude Code