Repository navigation
Latest typedb driver disables TLS differently - #145
Conversation
There was a problem hiding this comment.
Thanks for the fix @purcell ! Btw, please feel free to merge such smaller fixes without review from my side, going forward. 馃檶 (I know we are in the process of defining PR review guidelines for Engineering more broadly right now, but just wanted to mention :) )
|
Btw, just noticed that I never merged this PR (which may slightly overlap with some of your fixes): #138 What's the best way to proceed - do you want to take ownership here and cherry-pick any changes from #138 that could be relevant, and then either merge #138 or close it if we no longer need it? 馃檹 Please let me know how I can help! |
|
Thanks. A couple of the changes here are cleaner, e.g. there was no need to install libvirt in that other PR. I'll cherry-pick the remaining changes from there and apply them in a separate PR. I think that reviews are still required on this repo, and I'm not an admin, otherwise I probably would have merged directly. That's been fixed now so I can apply trivial fixes without review. |
This fixes CI for typedb, which appears to have broken over time as the interface of the upstream driver has changed.