Skip to content

Merge upstream/main (Oct 2026) - #27

Closed
sabir-akhadov-localstack wants to merge 142 commits into
mainfrom
sync/upstream-2026-10
Closed

sabir-akhadov-localstack wants to merge 142 commits into
mainfrom
sync/upstream-2026-10

Conversation

@sabir-akhadov-localstack

Copy link
Copy Markdown
Collaborator

Merges apache/datafusion-sqlparser-rs main (141 commits, up to 14cbf755) into the fork.

Three of our upstreamed PRs (apache#2370 visitor ident hooks, apache#2388 CREATE WAREHOUSE, apache#2396 CREATE OR REPLACE SCHEMA) landed upstream in adapted form, and upstream added its own CREATE FILE FORMAT (apache#2336). Resolutions:

  • CREATE WAREHOUSE → upstream's Statement::CreateWarehouse(CreateWarehouse) with parsed options (was a struct variant that skipped all properties). ⚠️ AST change for downstream consumers.
  • CREATE FILE FORMAT → kept the fork's AST/parser (superset: format_type, LIKE, ALTER/DROP/DESC/SHOW, COMMENT anywhere). Dropped upstream's 3 AST-shape tests that assumed its shape.
  • CREATE SCHEMA → fork's TRANSIENT / WITH MANAGED ACCESS kept on top of upstream.
  • CREATE PROCEDURE → fork's signature kept, plus upstream's PROC alias.
  • Visitor → upstream's (superset, adds ORDER BY / GROUP BY hooks); removed duplicated Ident visit impls.

cargo test --all-features passes. Branches stacked on main (e.g. tag-grammar work using the old CreateWarehouse {..} shape) will need to adapt when they merge this.

finchxxia and others added 30 commits May 2, 2026 04:52
…atements (apache#2325)

Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
LucaCappelletti94 and others added 27 commits September 24, 2026 20:51
…trait method (apache#2526)

Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: evieira <ethan.vieira@tryg.dk>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sync the fork with apache/datafusion-sqlparser-rs main (141 commits).

Notable conflict resolutions:
- CREATE WAREHOUSE: adopt upstream's `Statement::CreateWarehouse(CreateWarehouse)`
  (from our upstreamed apache#2388), which parses warehouse options instead of
  skipping them. Fork-only ALTER/DESC/SHOW WAREHOUSE are unchanged.
- CREATE FILE FORMAT: keep the fork's richer AST/parser (format_type,
  LIKE, ALTER/DROP/DESC/SHOW, COMMENT anywhere, VOLATILE as TEMPORARY)
  instead of upstream's apache#2336; drop upstream's duplicate AST-shape tests
  and adapt the IDENTIFIER(?) test to the fork's `TYPE = X` rendering.
- CREATE SCHEMA: keep fork's TRANSIENT / WITH MANAGED ACCESS on top of
  upstream's OR REPLACE (apache#2396).
- CREATE PROCEDURE: keep fork's (or_alter, or_replace) signature, add
  upstream's PROC alias.
- Visitor: take upstream's visitor.rs (superset, incl. ORDER BY / GROUP BY
  hooks); remove duplicated Ident Visit/VisitMut impls (apache#2370).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sabir-akhadov-localstack

Copy link
Copy Markdown
Collaborator Author

Closing: per snowflake-rs ADR 081 the fork's main tracks apache only and nothing builds from it; snowflake-rs picks up upstream via the upgrade-sqlparser replay flow instead.

@sabir-akhadov-localstack
sabir-akhadov-localstack deleted the sync/upstream-2026-10 branch October 6, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.