Repository navigation
Merge upstream/main (Oct 2026) - #27
Closed
sabir-akhadov-localstack wants to merge 142 commits into
Closed
sabir-akhadov-localstack wants to merge 142 commits into
sabir-akhadov-localstack wants to merge 142 commits into
Conversation
…atements (apache#2325) Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
…trait method (apache#2526) Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: evieira <ethan.vieira@tryg.dk> Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Co-authored-by: Luca Cappelletti <cappelletti.luca94@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sync the fork with apache/datafusion-sqlparser-rs main (141 commits). Notable conflict resolutions: - CREATE WAREHOUSE: adopt upstream's `Statement::CreateWarehouse(CreateWarehouse)` (from our upstreamed apache#2388), which parses warehouse options instead of skipping them. Fork-only ALTER/DESC/SHOW WAREHOUSE are unchanged. - CREATE FILE FORMAT: keep the fork's richer AST/parser (format_type, LIKE, ALTER/DROP/DESC/SHOW, COMMENT anywhere, VOLATILE as TEMPORARY) instead of upstream's apache#2336; drop upstream's duplicate AST-shape tests and adapt the IDENTIFIER(?) test to the fork's `TYPE = X` rendering. - CREATE SCHEMA: keep fork's TRANSIENT / WITH MANAGED ACCESS on top of upstream's OR REPLACE (apache#2396). - CREATE PROCEDURE: keep fork's (or_alter, or_replace) signature, add upstream's PROC alias. - Visitor: take upstream's visitor.rs (superset, incl. ORDER BY / GROUP BY hooks); remove duplicated Ident Visit/VisitMut impls (apache#2370). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
Closing: per snowflake-rs ADR 081 the fork's main tracks apache only and nothing builds from it; snowflake-rs picks up upstream via the upgrade-sqlparser replay flow instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
apache/datafusion-sqlparser-rsmain (141 commits, up to14cbf755) into the fork.Three of our upstreamed PRs (apache#2370 visitor ident hooks, apache#2388 CREATE WAREHOUSE, apache#2396 CREATE OR REPLACE SCHEMA) landed upstream in adapted form, and upstream added its own CREATE FILE FORMAT (apache#2336). Resolutions:
Statement::CreateWarehouse(CreateWarehouse)with parsedoptions(was a struct variant that skipped all properties).format_type,LIKE, ALTER/DROP/DESC/SHOW, COMMENT anywhere). Dropped upstream's 3 AST-shape tests that assumed its shape.TRANSIENT/WITH MANAGED ACCESSkept on top of upstream.PROCalias.Identvisit impls.cargo test --all-featurespasses. Branches stacked onmain(e.g. tag-grammar work using the oldCreateWarehouse {..}shape) will need to adapt when they merge this.