Skip to content

fix(mp): propagate remote handler failures to clients - #7

Open
voipmonitor wants to merge 1 commit into
release/v0.5.2-glm52-dcp-basefrom
fix/lmcache-mp-rpc-errors-20260729
Open

fix(mp): propagate remote handler failures to clients#7
voipmonitor wants to merge 1 commit into
release/v0.5.2-glm52-dcp-basefrom
fix/lmcache-mp-rpc-errors-20260729

Conversation

@voipmonitor

Copy link
Copy Markdown

Problem

A blocking or synchronous MP handler exception was only logged by the server. No response was sent, so the client MessagingFuture remained pending forever and vLLM requests could remain in WAITING_FOR_REMOTE_KVS.

Change

  • add exception completion to MessagingFuture
  • return a bounded, versioned RPC error envelope from sync and blocking handlers
  • surface remote failures as RemoteHandlerError on the client
  • keep ZMQ access on the server loop by queueing callback responses
  • return an explicit error for unregistered request types

The wire change is error-only: successful response frames are unchanged. Error payloads contain the exception type and a message capped at 4096 bytes; server tracebacks stay in server logs.

Validation

  • Ruff check and format pass
  • 33 MQ/future tests pass; 13 CUDA-only tests skip in the test container
  • sync exception completes the future and the same polling loop processes a later healthy request
  • blocking exception completes the future instead of timing out

Reported by Florian Bernd during GLM-5.2 LMCache testing. This PR is intentionally the first layer; retrieve recovery and storage policy changes remain separate.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@voipmonitor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5073e92-67ac-4f29-8348-843196fce638

📥 Commits

Reviewing files that changed from the base of the PR and between 9cebd40 and 7b7583a.

📒 Files selected for processing (5)
  • lmcache/v1/multiprocess/futures.py
  • lmcache/v1/multiprocess/mq.py
  • tests/v1/multiprocess/test_futures.py
  • tests/v1/multiprocess/test_mq.py
  • tests/v1/multiprocess/test_mq_handler_helpers.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@voipmonitor

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant